[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/21] hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of
From: |
Gerd Hoffmann |
Subject: |
[PULL 04/21] hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of debug printf |
Date: |
Thu, 28 May 2020 14:35:52 +0200 |
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Replace some debug printf() calls by qemu_log_mask(LOG_UNIMP),
and add a new one in cirrus_linear_bitblt_read().
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-5-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/cirrus_vga.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
index 33ccdde00061..f9f837b8508c 100644
--- a/hw/display/cirrus_vga.c
+++ b/hw/display/cirrus_vga.c
@@ -35,6 +35,7 @@
#include "qemu/osdep.h"
#include "qemu/module.h"
#include "qemu/units.h"
+#include "qemu/log.h"
#include "sysemu/reset.h"
#include "qapi/error.h"
#include "trace.h"
@@ -905,9 +906,8 @@ static int cirrus_bitblt_cputovideo(CirrusVGAState * s)
static int cirrus_bitblt_videotocpu(CirrusVGAState * s)
{
/* XXX */
-#ifdef DEBUG_BITBLT
- printf("cirrus: bitblt (video to cpu) is not implemented yet\n");
-#endif
+ qemu_log_mask(LOG_UNIMP,
+ "cirrus: bitblt (video to cpu) is not implemented\n");
return 0;
}
@@ -989,9 +989,8 @@ static void cirrus_bitblt_start(CirrusVGAState * s)
cirrus_blt_mode & (CIRRUS_BLTMODE_MEMSYSSRC |
CIRRUS_BLTMODE_MEMSYSDEST))
== (CIRRUS_BLTMODE_MEMSYSSRC | CIRRUS_BLTMODE_MEMSYSDEST)) {
-#ifdef DEBUG_BITBLT
- printf("cirrus: bitblt - memory-to-memory copy is requested\n");
-#endif
+ qemu_log_mask(LOG_UNIMP,
+ "cirrus: bitblt - memory-to-memory copy requested\n");
goto bitblt_ignore;
}
@@ -2412,6 +2411,9 @@ static uint64_t cirrus_linear_bitblt_read(void *opaque,
/* XXX handle bitblt */
(void)s;
+ qemu_log_mask(LOG_UNIMP,
+ "cirrus: linear bitblt is not implemented\n");
+
return 0xff;
}
--
2.18.4
- [PULL 00/21] Vga 20200528 patches, Gerd Hoffmann, 2020/05/28
- [PULL 04/21] hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of debug printf,
Gerd Hoffmann <=
- [PULL 03/21] hw/display/cirrus_vga: Convert debug printf() to trace event, Gerd Hoffmann, 2020/05/28
- [PULL 02/21] hw/display/cg3: Convert debug printf()s to trace events, Gerd Hoffmann, 2020/05/28
- [PULL 13/21] hw/display/omap_dss: Replace fprintf() call by qemu_log_mask(LOG_UNIMP), Gerd Hoffmann, 2020/05/28
- [PULL 18/21] sm501: Clean up local variables in sm501_2d_operation, Gerd Hoffmann, 2020/05/28
- [PULL 12/21] hw/display/exynos4210_fimd: Use qemu_log_mask(GUEST_ERROR), Gerd Hoffmann, 2020/05/28
- [PULL 10/21] hw/display/vmware_vga: Replace printf() calls by qemu_log_mask(ERROR), Gerd Hoffmann, 2020/05/28
- [PULL 08/21] hw/display/dpcd: Convert debug printf()s to trace events, Gerd Hoffmann, 2020/05/28
- [PULL 15/21] sm501: Convert printf + abort to qemu_log_mask, Gerd Hoffmann, 2020/05/28
- [PULL 20/21] sm501: Optimize small overlapping blits, Gerd Hoffmann, 2020/05/28
- [PULL 17/21] sm501: Use BIT(x) macro to shorten constant, Gerd Hoffmann, 2020/05/28