[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/21] hw/display/vmware_vga: Replace printf() calls by qemu_log_m
From: |
Gerd Hoffmann |
Subject: |
[PULL 10/21] hw/display/vmware_vga: Replace printf() calls by qemu_log_mask(ERROR) |
Date: |
Thu, 28 May 2020 14:35:58 +0200 |
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Avoid flooding stdio by converting printf() calls to
qemu_log_mask(GUEST_ERROR), which are disabled by default.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-11-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/vmware_vga.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
index 58ea82e3e581..5c0fc49d9d6e 100644
--- a/hw/display/vmware_vga.c
+++ b/hw/display/vmware_vga.c
@@ -26,6 +26,7 @@
#include "qemu/module.h"
#include "qemu/units.h"
#include "qapi/error.h"
+#include "qemu/log.h"
#include "hw/loader.h"
#include "trace.h"
#include "ui/vnc.h"
@@ -953,7 +954,8 @@ static uint32_t vmsvga_value_read(void *opaque, uint32_t
address)
ret = s->scratch[s->index - SVGA_SCRATCH_BASE];
break;
}
- printf("%s: Bad register %02x\n", __func__, s->index);
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "%s: Bad register %02x\n", __func__, s->index);
ret = 0;
break;
}
@@ -1002,7 +1004,8 @@ static void vmsvga_value_write(void *opaque, uint32_t
address, uint32_t value)
s->new_width = value;
s->invalidated = 1;
} else {
- printf("%s: Bad width: %i\n", __func__, value);
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "%s: Bad width: %i\n", __func__, value);
}
break;
@@ -1011,13 +1014,15 @@ static void vmsvga_value_write(void *opaque, uint32_t
address, uint32_t value)
s->new_height = value;
s->invalidated = 1;
} else {
- printf("%s: Bad height: %i\n", __func__, value);
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "%s: Bad height: %i\n", __func__, value);
}
break;
case SVGA_REG_BITS_PER_PIXEL:
if (value != 32) {
- printf("%s: Bad bits per pixel: %i bits\n", __func__, value);
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "%s: Bad bits per pixel: %i bits\n", __func__,
value);
s->config = 0;
s->invalidated = 1;
}
@@ -1082,7 +1087,8 @@ static void vmsvga_value_write(void *opaque, uint32_t
address, uint32_t value)
s->scratch[s->index - SVGA_SCRATCH_BASE] = value;
break;
}
- printf("%s: Bad register %02x\n", __func__, s->index);
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "%s: Bad register %02x\n", __func__, s->index);
}
}
--
2.18.4
- [PULL 00/21] Vga 20200528 patches, Gerd Hoffmann, 2020/05/28
- [PULL 04/21] hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of debug printf, Gerd Hoffmann, 2020/05/28
- [PULL 03/21] hw/display/cirrus_vga: Convert debug printf() to trace event, Gerd Hoffmann, 2020/05/28
- [PULL 02/21] hw/display/cg3: Convert debug printf()s to trace events, Gerd Hoffmann, 2020/05/28
- [PULL 13/21] hw/display/omap_dss: Replace fprintf() call by qemu_log_mask(LOG_UNIMP), Gerd Hoffmann, 2020/05/28
- [PULL 18/21] sm501: Clean up local variables in sm501_2d_operation, Gerd Hoffmann, 2020/05/28
- [PULL 12/21] hw/display/exynos4210_fimd: Use qemu_log_mask(GUEST_ERROR), Gerd Hoffmann, 2020/05/28
- [PULL 10/21] hw/display/vmware_vga: Replace printf() calls by qemu_log_mask(ERROR),
Gerd Hoffmann <=
- [PULL 08/21] hw/display/dpcd: Convert debug printf()s to trace events, Gerd Hoffmann, 2020/05/28
- [PULL 15/21] sm501: Convert printf + abort to qemu_log_mask, Gerd Hoffmann, 2020/05/28
- [PULL 20/21] sm501: Optimize small overlapping blits, Gerd Hoffmann, 2020/05/28
- [PULL 17/21] sm501: Use BIT(x) macro to shorten constant, Gerd Hoffmann, 2020/05/28
- [PULL 21/21] sm501: Remove obsolete changelog and todo comment, Gerd Hoffmann, 2020/05/28
- [PULL 16/21] sm501: Shorten long variable names in sm501_2d_operation, Gerd Hoffmann, 2020/05/28
- [PULL 06/21] hw/display/cirrus_vga: Convert debug printf() to trace event, Gerd Hoffmann, 2020/05/28
- [PULL 11/21] hw/display/vmware_vga: Let the PCI device own its I/O MemoryRegion, Gerd Hoffmann, 2020/05/28
- [PULL 19/21] sm501: Replace hand written implementation with pixman where possible, Gerd Hoffmann, 2020/05/28
- [PULL 14/21] hw/display/pxa2xx_lcd: Replace printf() call by qemu_log_mask(), Gerd Hoffmann, 2020/05/28