[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 01/18] target/i386: sev: Remove unused QSevGuestInfoClass
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [RFC v2 01/18] target/i386: sev: Remove unused QSevGuestInfoClass |
Date: |
Fri, 29 May 2020 11:01:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 5/21/20 5:42 AM, David Gibson wrote:
> This structure is nothing but an empty wrapper around the parent class,
> which by QOM conventions means we don't need it at all.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> target/i386/sev.c | 1 -
> target/i386/sev_i386.h | 5 -----
> 2 files changed, 6 deletions(-)
>
> diff --git a/target/i386/sev.c b/target/i386/sev.c
> index 51cdbe5496..2312510cf2 100644
> --- a/target/i386/sev.c
> +++ b/target/i386/sev.c
> @@ -287,7 +287,6 @@ static const TypeInfo qsev_guest_info = {
> .name = TYPE_QSEV_GUEST_INFO,
> .instance_size = sizeof(QSevGuestInfo),
> .instance_finalize = qsev_guest_finalize,
> - .class_size = sizeof(QSevGuestInfoClass),
> .class_init = qsev_guest_class_init,
> .instance_init = qsev_guest_init,
> .interfaces = (InterfaceInfo[]) {
> diff --git a/target/i386/sev_i386.h b/target/i386/sev_i386.h
> index 8ada9d385d..4f193642ac 100644
> --- a/target/i386/sev_i386.h
> +++ b/target/i386/sev_i386.h
> @@ -41,7 +41,6 @@ extern char *sev_get_launch_measurement(void);
> extern SevCapability *sev_get_capabilities(void);
>
> typedef struct QSevGuestInfo QSevGuestInfo;
> -typedef struct QSevGuestInfoClass QSevGuestInfoClass;
>
> /**
> * QSevGuestInfo:
> @@ -64,10 +63,6 @@ struct QSevGuestInfo {
> uint32_t reduced_phys_bits;
> };
>
> -struct QSevGuestInfoClass {
> - ObjectClass parent_class;
> -};
> -
> struct SEVState {
> QSevGuestInfo *sev_info;
> uint8_t api_major;
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [RFC v2 00/18] Refactor configuration of guest memory protection, David Gibson, 2020/05/20
- [RFC v2 02/18] target/i386: sev: Move local structure definitions into .c file, David Gibson, 2020/05/20
- [RFC v2 01/18] target/i386: sev: Remove unused QSevGuestInfoClass, David Gibson, 2020/05/20
- Re: [RFC v2 01/18] target/i386: sev: Remove unused QSevGuestInfoClass,
Philippe Mathieu-Daudé <=
- [RFC v2 04/18] target/i386: sev: Embed SEVState in SevGuestState, David Gibson, 2020/05/20
- [RFC v2 07/18] target/i386: sev: Remove redundant policy field, David Gibson, 2020/05/20
- [RFC v2 11/18] guest memory protection: Handle memory encrption via interface, David Gibson, 2020/05/20
- [RFC v2 09/18] target/i386: sev: Unify SEVState and SevGuestState, David Gibson, 2020/05/20
- [RFC v2 03/18] target/i386: sev: Rename QSevGuestInfo, David Gibson, 2020/05/20
- [RFC v2 05/18] target/i386: sev: Partial cleanup to sev_state global, David Gibson, 2020/05/20