[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 09/18] target/i386: sev: Unify SEVState and SevGuestState
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [RFC v2 09/18] target/i386: sev: Unify SEVState and SevGuestState |
Date: |
Fri, 29 May 2020 11:13:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 5/21/20 5:42 AM, David Gibson wrote:
> SEVState is contained with SevGuestState. We've now fixed redundancies
> and name conflicts, so there's no real point to the nested structure. Just
> move all the fields of SEVState into SevGuestState.
>
> This eliminates the SEVState structure, which as a bonus removes the
> confusion with the SevState enum.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> target/i386/sev.c | 79 ++++++++++++++++++++---------------------------
> 1 file changed, 34 insertions(+), 45 deletions(-)
[...]
> sev_guest = sev;
> - s = &sev->state;
> - s->state = SEV_STATE_UNINIT;
> + sev->state = SEV_STATE_UNINIT;
:)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [RFC v2 02/18] target/i386: sev: Move local structure definitions into .c file, (continued)
- [RFC v2 02/18] target/i386: sev: Move local structure definitions into .c file, David Gibson, 2020/05/20
- [RFC v2 01/18] target/i386: sev: Remove unused QSevGuestInfoClass, David Gibson, 2020/05/20
- [RFC v2 04/18] target/i386: sev: Embed SEVState in SevGuestState, David Gibson, 2020/05/20
- [RFC v2 07/18] target/i386: sev: Remove redundant policy field, David Gibson, 2020/05/20
- [RFC v2 11/18] guest memory protection: Handle memory encrption via interface, David Gibson, 2020/05/20
- [RFC v2 09/18] target/i386: sev: Unify SEVState and SevGuestState, David Gibson, 2020/05/20
- Re: [RFC v2 09/18] target/i386: sev: Unify SEVState and SevGuestState,
Philippe Mathieu-Daudé <=
- [RFC v2 03/18] target/i386: sev: Rename QSevGuestInfo, David Gibson, 2020/05/20
- [RFC v2 05/18] target/i386: sev: Partial cleanup to sev_state global, David Gibson, 2020/05/20
- [RFC v2 08/18] target/i386: sev: Remove redundant handle field, David Gibson, 2020/05/20
- [RFC v2 12/18] guest memory protection: Perform KVM init via interface, David Gibson, 2020/05/20
- [RFC v2 13/18] guest memory protection: Move side effect out of machine_set_memory_encryption(), David Gibson, 2020/05/20
- [RFC v2 15/18] guest memory protection: Decouple kvm_memcrypt_*() helpers from KVM, David Gibson, 2020/05/20
- [RFC v2 06/18] target/i386: sev: Remove redundant cbitpos and reduced_phys_bits fields, David Gibson, 2020/05/20
- [RFC v2 14/18] guest memory protection: Rework the "memory-encryption" property, David Gibson, 2020/05/20