Re: [RFC PATCH v2 2/7] target/ppc: Implemented xvi*ger* instructions

[Lucas Mateus Martins Araujo e Castro]

On 08/05/2022 00:41, Richard Henderson wrote:

> On
>       5/6/22 07:18, Lucas Mateus Castro(alqotel) wrote:
>       
> > diff --git a/target/ppc/cpu.h
> >         b/target/ppc/cpu.h
> >         
> >         index 10c6d7ae43..348a898950 100644
> >         
> >         --- a/target/ppc/cpu.h
> >         
> >         +++ b/target/ppc/cpu.h
> >         
> >         @@ -238,6 +238,7 @@ typedef union _ppc_vsr_t {
> >         
> >         
> >           typedef ppc_vsr_t ppc_avr_t;
> >         
> >           typedef ppc_vsr_t ppc_fprp_t;
> >         
> >         +typedef ppc_vsr_t ppc_acc_t;
> >         
> >         
> >           #if !defined(CONFIG_USER_ONLY)
> >         
> >           /* Software TLB cache */
> >         
> >         diff --git a/target/ppc/helper.h b/target/ppc/helper.h
> >         
> >         index aa6773c4a5..61217e0a10 100644
> >         
> >         --- a/target/ppc/helper.h
> >         
> >         +++ b/target/ppc/helper.h
> >         
> >         @@ -537,6 +537,15 @@ DEF_HELPER_5(XXBLENDVB, void, vsr, vsr,
> >         vsr, vsr, i32)
> >         
> >           DEF_HELPER_5(XXBLENDVH, void, vsr, vsr, vsr, vsr, i32)
> >         
> >           DEF_HELPER_5(XXBLENDVW, void, vsr, vsr, vsr, vsr, i32)
> >         
> >           DEF_HELPER_5(XXBLENDVD, void, vsr, vsr, vsr, vsr, i32)
> >         
> >         +DEF_HELPER_5(XVI4GER8, void, env, vsr, vsr, vsr, i32)
> >         
> >         +DEF_HELPER_5(XVI4GER8PP, void, env, vsr, vsr, vsr, i32)
> >         
> >         +DEF_HELPER_5(XVI8GER4, void, env, vsr, vsr, vsr, i32)
> >         
> >         +DEF_HELPER_5(XVI8GER4PP, void, env, vsr, vsr, vsr, i32)
> >         
> >         +DEF_HELPER_5(XVI8GER4SPP, void, env, vsr, vsr, vsr, i32)
> >         
> >         +DEF_HELPER_5(XVI16GER2, void, env, vsr, vsr, vsr, i32)
> >         
> >         +DEF_HELPER_5(XVI16GER2S, void, env, vsr, vsr, vsr, i32)
> >         
> >         +DEF_HELPER_5(XVI16GER2PP, void, env, vsr, vsr, vsr, i32)
> >         
> >         +DEF_HELPER_5(XVI16GER2SPP, void, env, vsr, vsr, vsr, i32)
> >         
> >       
>       
>       Did you intend to use "acc" here, for documentation purposes?
>       
>       It's just a couple of #defines above.
>       
>

Yes, I'll change that in the next version, do you want me to keep the Reviewed-by or do I sent without them so you can review the changes?

It'll be just adding

    #define dh_alias_acc ptr
    #define dh_ctype_acc ppc_acc_t *
    #define dh_typecode_acc dh_typecode_ptr

and changing DEF_HELPER_5 to have acc instead of the third vsr

>       
>       Either way, much cleaner.
>       
>       Reviewed-by: Richard Henderson
>       <richard.henderson@linaro.org>
>       
>       
>       
>       r~
>       
>

--
Lucas Mateus M. Araujo e Castro
Instituto de Pesquisas ELDORADO
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer