Re: [RFC PATCH v2 3/7] target/ppc: Implemented pmxvi*ger* instructions

[Lucas Mateus Martins Araujo e Castro]

On 08/05/2022 00:48, Richard Henderson wrote:

> On
>       5/6/22 07:18, Lucas Mateus Castro(alqotel) wrote:
>       
>       
> > +{
> >         
> >         +    arg_MMIRR_XX3 m;
> >         
> >         +    m.xa = a->xa;
> >         
> >         +    m.xb = a->xb;
> >         
> >         +    m.xt = a->xt;
> >         
> >         +    m.pmsk = 0xFF;
> >         
> >         +    m.ymsk = 0xF;
> >         
> >         +    m.xmsk = 0xF;
> >         
> >         +    return do_ger_MMIRR_XX3(ctx, &m, helper);
> >         
> >           }
> >         
> >       
>       
>       Is XX3 going to be used for anything else?  Is it worthwhile to
>       move these into the
>       
>       decoder as explicit assignments?
>       
>     
    XX3 and MMIRR_XX3 are in different decodetree files, I'll change all
    instructions to use MMIRR_XX3 for the next patch but I'll have to
    change MMIRR_XX3 declaration in target/ppc/insn64.decode to have an
    !extern in it (since it'll need to also be declared in
    target/ppc/insn32.decode)
>       
>       Either way,
>       
>       Reviewed-by: Richard Henderson
>       <richard.henderson@linaro.org>
>       
>       
>       r~
>       
>

--
Lucas Mateus M. Araujo e Castro
Instituto de Pesquisas ELDORADO
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer