[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/9] target/ppc: use g_autofree in kvmppc_read_int_cpu_dt()
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH 4/9] target/ppc: use g_autofree in kvmppc_read_int_cpu_dt() |
Date: |
Thu, 30 Jun 2022 16:42:44 -0300 |
This spares us a g_free() call. Let's also not use 'val' and return the
value of kvmppc_read_int_dt() directly.
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
target/ppc/kvm.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
index 7611e9ccf6..c218380eb7 100644
--- a/target/ppc/kvm.c
+++ b/target/ppc/kvm.c
@@ -1932,8 +1932,8 @@ static uint64_t kvmppc_read_int_dt(const char *filename,
Error **errp)
*/
static uint64_t kvmppc_read_int_cpu_dt(const char *propname, Error **errp)
{
- char buf[PATH_MAX], *tmp;
- uint64_t val;
+ g_autofree char *tmp = NULL;
+ char buf[PATH_MAX];
if (kvmppc_find_cpu_dt(buf, sizeof(buf))) {
error_setg(errp, "Failed to read CPU property %s", propname);
@@ -1941,10 +1941,8 @@ static uint64_t kvmppc_read_int_cpu_dt(const char
*propname, Error **errp)
}
tmp = g_strdup_printf("%s/%s", buf, propname);
- val = kvmppc_read_int_dt(tmp, errp);
- g_free(tmp);
- return val;
+ return kvmppc_read_int_dt(tmp, errp);
}
uint64_t kvmppc_get_clockfreq(void)
--
2.36.1
- [PATCH 0/9] cleanup error handling in kvmppc_read_int_cpu_dt(), Daniel Henrique Barboza, 2022/06/30
- [PATCH 1/9] target/ppc/kvm.c: do not return -1 on uint64_t return, Daniel Henrique Barboza, 2022/06/30
- [PATCH 4/9] target/ppc: use g_autofree in kvmppc_read_int_cpu_dt(),
Daniel Henrique Barboza <=
- [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt(), Daniel Henrique Barboza, 2022/06/30
- [PATCH 9/9] spapr.c: handle clock freq read errors in spapr_dt_cpu(), Daniel Henrique Barboza, 2022/06/30
- [PATCH 6/9] ppc440_bamboo.c: handle clock freq read error in load_device_tree, Daniel Henrique Barboza, 2022/06/30
- [PATCH 3/9] target/ppc: Add error reporting when opening file fails, Daniel Henrique Barboza, 2022/06/30
- [PATCH 5/9] target/ppc: use Error pointer in kvmppc_get_clockfreq(), Daniel Henrique Barboza, 2022/06/30
- [PATCH 7/9] sam460ex.c: use CPU_FREQ if unable to read DT clock, Daniel Henrique Barboza, 2022/06/30
- [PATCH 8/9] e500.c: use PLATFORM_CLK_FREQ_HZ if unable to read clock freq from DT, Daniel Henrique Barboza, 2022/06/30