[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/9] target/ppc: Add error reporting when opening file fails
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH 3/9] target/ppc: Add error reporting when opening file fails |
Date: |
Thu, 30 Jun 2022 16:42:43 -0300 |
From: jianchunfu <jianchunfu@cmss.chinamobile.com>
Add error reporting before return when opening file fails in
kvmppc_read_int_dt().
Signed-off-by: jianchunfu <jianchunfu@cmss.chinamobile.com>
[danielhb: use error_setg() instead of fprintf]
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
target/ppc/kvm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
index bc17437097..7611e9ccf6 100644
--- a/target/ppc/kvm.c
+++ b/target/ppc/kvm.c
@@ -1896,7 +1896,7 @@ static int kvmppc_find_cpu_dt(char *buf, int buf_len)
return 0;
}
-static uint64_t kvmppc_read_int_dt(const char *filename)
+static uint64_t kvmppc_read_int_dt(const char *filename, Error **errp)
{
union {
uint32_t v32;
@@ -1907,6 +1907,7 @@ static uint64_t kvmppc_read_int_dt(const char *filename)
f = fopen(filename, "rb");
if (!f) {
+ error_setg(errp, "Error opening %s: %s", filename, strerror(errno));
return 0;
}
@@ -1940,7 +1941,7 @@ static uint64_t kvmppc_read_int_cpu_dt(const char
*propname, Error **errp)
}
tmp = g_strdup_printf("%s/%s", buf, propname);
- val = kvmppc_read_int_dt(tmp);
+ val = kvmppc_read_int_dt(tmp, errp);
g_free(tmp);
return val;
--
2.36.1
- [PATCH 0/9] cleanup error handling in kvmppc_read_int_cpu_dt(), Daniel Henrique Barboza, 2022/06/30
- [PATCH 1/9] target/ppc/kvm.c: do not return -1 on uint64_t return, Daniel Henrique Barboza, 2022/06/30
- [PATCH 4/9] target/ppc: use g_autofree in kvmppc_read_int_cpu_dt(), Daniel Henrique Barboza, 2022/06/30
- [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt(), Daniel Henrique Barboza, 2022/06/30
- [PATCH 9/9] spapr.c: handle clock freq read errors in spapr_dt_cpu(), Daniel Henrique Barboza, 2022/06/30
- [PATCH 6/9] ppc440_bamboo.c: handle clock freq read error in load_device_tree, Daniel Henrique Barboza, 2022/06/30
- [PATCH 3/9] target/ppc: Add error reporting when opening file fails,
Daniel Henrique Barboza <=
- [PATCH 5/9] target/ppc: use Error pointer in kvmppc_get_clockfreq(), Daniel Henrique Barboza, 2022/06/30
- [PATCH 7/9] sam460ex.c: use CPU_FREQ if unable to read DT clock, Daniel Henrique Barboza, 2022/06/30
- [PATCH 8/9] e500.c: use PLATFORM_CLK_FREQ_HZ if unable to read clock freq from DT, Daniel Henrique Barboza, 2022/06/30