Re: [PATCH] ppc/pegasos2: Improve readability of VIA south bridge creation

[Philippe Mathieu-Daudé]

On 17/1/23 22:57, BALATON Zoltan wrote:
> On Tue, 17 Jan 2023, BALATON Zoltan wrote:
> > Slightly improve readability of creating the south btidge by cnamging
>
> Still left a typo in "bridge" above...

Also "naming".

> This is alternative, inspired by Phil's patches, maybe I'd also need to 
> add Inspired-by: tag.

Not necessary.

> > type of a local variable to avoid some casts within function arguments
> > which makes some lines shorter and easier to read.
> > Also remove an unneded line break.
>
> and "unneeded" here. I wait what Phil says then correct these if needed.

Fine by me, so with the typos fixed:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> > ---
> > hw/ppc/pegasos2.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)