Re: [PATCH v2 2/4] bulk: Coding style fixes

[Thomas Huth]

On 11/01/2023 09.39, Philippe Mathieu-Daudé wrote:
> Fix the following checkpatch.pl violation on lines using the
> TARGET_FMT_plx definition to avoid:
>
>    WARNING: line over 80 characters

It's just a warning...

> @@ -420,8 +421,9 @@ static int get_segment_6xx_tlb(CPUPPCState *env, mmu_ctx_t 
> *ctx,
>                   hwaddr curaddr;
>                   uint32_t a0, a1, a2, a3;
>   
> -                qemu_log("Page table: " TARGET_FMT_plx " len " TARGET_FMT_plx
> -                         "\n", ppc_hash32_hpt_base(cpu),
> +                qemu_log("Page table: " TARGET_FMT_plx
> +                         " len " TARGET_FMT_plx "\n",
> +                         ppc_hash32_hpt_base(cpu),
>                            ppc_hash32_hpt_mask(cpu) + 0x80);
>                   for (curaddr = ppc_hash32_hpt_base(cpu);
>                        curaddr < (ppc_hash32_hpt_base(cpu)

... and in cases like this, I'd really prefer the original line.

I think it would be better to just fix it if checkpatch.pl really throws an 
ERROR instead of a WARNING.

 Thomas