Re: [PATCH v3 16/18] hw/sm501: allow compiling without PIXMAN

[BALATON Zoltan]

On Tue, 10 Oct 2023, BALATON Zoltan wrote:
> > @@ -2169,8 +2195,10 @@ static void sm501_pci_class_init(ObjectClass *klass, 
> > void *data)
> >
> > static void sm501_pci_init(Object *o)
> > {
> > +#ifdef CONFIG_PIXMAN
>
> Do you still need the ifdef here if we keep the property even with !PIXMAN?

Maybe you intended to remove this help message because the option does not 
work as documented here. In that case maybe add an #else with help saying 
not effective without PIXMAN, always 0 or similiar.

Regards,
BALATON Zoltan

> >     object_property_set_description(o, "x-pixman", "Use pixman for: "
> >                                     "1: fill, 2: blit, 4: overlap blit");
> > +#endif
> > }
> >
> > static const TypeInfo sm501_pci_info = {