[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 16/18] hw/sm501: allow compiling without PIXMAN
|
From: |
Marc-André Lureau |
|
Subject: |
Re: [PATCH v3 16/18] hw/sm501: allow compiling without PIXMAN |
|
Date: |
Tue, 10 Oct 2023 17:40:05 +0400 |
Hi
On Tue, Oct 10, 2023 at 4:30 PM BALATON Zoltan <balaton@eik.bme.hu> wrote:
>
> On Tue, 10 Oct 2023, BALATON Zoltan wrote:
> >> @@ -2169,8 +2195,10 @@ static void sm501_pci_class_init(ObjectClass *klass,
> >> void *data)
> >>
> >> static void sm501_pci_init(Object *o)
> >> {
> >> +#ifdef CONFIG_PIXMAN
> >
> > Do you still need the ifdef here if we keep the property even with !PIXMAN?
>
> Maybe you intended to remove this help message because the option does not
> work as documented here. In that case maybe add an #else with help saying
> not effective without PIXMAN, always 0 or similiar.
>
Right, I'll simply remove the #ifdef
- [PATCH v3 08/18] ui/console: when PIXMAN is unavailable, don't draw placeholder msg, (continued)
- [PATCH v3 08/18] ui/console: when PIXMAN is unavailable, don't draw placeholder msg, marcandre . lureau, 2023/10/10
- [PATCH v3 09/18] vhost-user-gpu: skip VHOST_USER_GPU_UPDATE when !PIXMAN, marcandre . lureau, 2023/10/10
- [PATCH v3 10/18] ui/gl: opengl doesn't require PIXMAN, marcandre . lureau, 2023/10/10
- [PATCH v3 07/18] virtio-gpu: replace PIXMAN for region/rect test, marcandre . lureau, 2023/10/10
- [PATCH v3 11/18] ui/vnc: VNC requires PIXMAN, marcandre . lureau, 2023/10/10
- [PATCH v3 12/18] ui/spice: SPICE/QXL requires PIXMAN, marcandre . lureau, 2023/10/10
- [PATCH v3 15/18] arm/kconfig: XLNX_ZYNQMP_ARM depends on PIXMAN, marcandre . lureau, 2023/10/10
- [PATCH v3 16/18] hw/sm501: allow compiling without PIXMAN, marcandre . lureau, 2023/10/10
- [PATCH v3 18/18] build-sys: make pixman actually optional, marcandre . lureau, 2023/10/10
- [PATCH v3 13/18] ui/gtk: -display gtk requires PIXMAN, marcandre . lureau, 2023/10/10
- [PATCH v3 14/18] ui/dbus: do not require PIXMAN, marcandre . lureau, 2023/10/10
- [PATCH v3 17/18] hw/display: make ATI_VGA depend on PIXMAN, marcandre . lureau, 2023/10/10