[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 41/61] target/ppc/mmu_common.c: Return directly in ppc6xx_tlb_
From: |
BALATON Zoltan |
Subject: |
[PATCH v7 41/61] target/ppc/mmu_common.c: Return directly in ppc6xx_tlb_pte_check() |
Date: |
Mon, 13 May 2024 01:28:15 +0200 (CEST) |
Instead of using a local ret variable return directly and remove the
local.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
target/ppc/mmu_common.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c
index 0c7cbab2bc..a035cefcad 100644
--- a/target/ppc/mmu_common.c
+++ b/target/ppc/mmu_common.c
@@ -98,9 +98,6 @@ static int ppc6xx_tlb_pte_check(mmu_ctx_t *ctx, target_ulong
pte0,
target_ulong pte1, int pteh,
MMUAccessType access_type)
{
- int ret;
-
- ret = -1;
/* Check validity and table match */
if (pte_is_valid(pte0) && ((pte0 >> 6) & 1) == pteh) {
/* Check vsid & api */
@@ -119,16 +116,15 @@ static int ppc6xx_tlb_pte_check(mmu_ctx_t *ctx,
target_ulong pte0,
if (check_prot_access_type(ctx->prot, access_type)) {
/* Access granted */
qemu_log_mask(CPU_LOG_MMU, "PTE access granted !\n");
- ret = 0;
+ return 0;
} else {
/* Access right violation */
qemu_log_mask(CPU_LOG_MMU, "PTE access rejected\n");
- ret = -2;
+ return -2;
}
}
}
-
- return ret;
+ return -1;
}
/* Software driven TLB helpers */
--
2.30.9
- [PATCH v7 29/61] target/ppc: Remove id_tlbs flag from CPU env, (continued)
- [PATCH v7 29/61] target/ppc: Remove id_tlbs flag from CPU env, BALATON Zoltan, 2024/05/12
- [PATCH v7 31/61] target/ppc/mmu-hash32.c: Drop a local variable, BALATON Zoltan, 2024/05/12
- [PATCH v7 32/61] target/ppc/mmu-radix64.c: Drop a local variable, BALATON Zoltan, 2024/05/12
- [PATCH v7 35/61] target/ppc: Remove pp_check() and reuse ppc_hash32_pp_prot(), BALATON Zoltan, 2024/05/12
- [PATCH v7 37/61] target/ppc/mmu_common.c: Remove single use local variable, BALATON Zoltan, 2024/05/12
- [PATCH v7 39/61] target/ppc/mmu_common.c: Remove another single use local, BALATON Zoltan, 2024/05/12
- [PATCH v7 33/61] target/ppc: Add a function to check for page protection bit, BALATON Zoltan, 2024/05/12
- [PATCH v7 41/61] target/ppc/mmu_common.c: Return directly in ppc6xx_tlb_pte_check(),
BALATON Zoltan <=
- [PATCH v7 36/61] target/ppc/mmu_common.c: Remove local name for a constant, BALATON Zoltan, 2024/05/12
- [PATCH v7 38/61] target/ppc/mmu_common.c: Remove single use local variable, BALATON Zoltan, 2024/05/12
- [PATCH v7 40/61] target/ppc/mmu_common.c: Remove yet another single use local, BALATON Zoltan, 2024/05/12
- [PATCH v7 42/61] target/ppc/mmu_common.c: Simplify ppc6xx_tlb_pte_check(), BALATON Zoltan, 2024/05/12
- [PATCH v7 43/61] target/ppc/mmu_common.c: Remove unused field from mmu_ctx_t, BALATON Zoltan, 2024/05/12
- [PATCH v7 44/61] target/ppc/mmu_common.c: Remove hash field from mmu_ctx_t, BALATON Zoltan, 2024/05/12
- [PATCH v7 51/61] target/ppc: Add function to get protection key for hash32 MMU, BALATON Zoltan, 2024/05/12
- [PATCH v7 52/61] target/ppc/mmu-hash32.c: Inline and remove ppc_hash32_pte_prot(), BALATON Zoltan, 2024/05/12