[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] target/riscv: Fix tb->flags FS status
From: |
Richard Henderson |
Subject: |
Re: [PATCH v2 1/3] target/riscv: Fix tb->flags FS status |
Date: |
Tue, 14 Jan 2020 05:29:39 -1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 1/14/20 12:13 AM, address@hidden wrote:
> if (riscv_cpu_fp_enabled(env)) {
> - *flags |= TB_FLAGS_MSTATUS_FS;
> + *flags |= env->mstatus & MSTATUS_FS;
> }
Note that riscv_cpu_fp_enabled is *also* testing env->mstatus, and that this
assignment can be made unconditional.
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~