|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH rc2 12/25] hw/timer: Add limited support for Atmel 16 bit timer peripheral |
Date: | Fri, 24 Jan 2020 13:52:55 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 1/24/20 11:42 AM, Alex Bennée wrote:
Philippe Mathieu-Daudé <address@hidden> writes:From: Michael Rolnik <address@hidden> These were designed to facilitate testing but should provide enough function to be useful in other contexts. Only a subset of the functions of each peripheral is implemented, mainly due to the lack of a standard way to handle electrical connections (like GPIO pins). Signed-off-by: Sarah Harris <address@hidden> Message-Id: <address@hidden> Signed-off-by: Philippe Mathieu-Daudé <address@hidden> [rth: Squash info mtree fixes and a file rename from f4bug, which was:] Suggested-by: Aleksandar Markovic <address@hidden> Signed-off-by: Richard Henderson <address@hidden> [PMD: Use qemu_log_mask(LOG_UNIMP), replace goto by return] Signed-off-by: Philippe Mathieu-Daudé <address@hidden> ---
<snip>
--- /dev/null +++ b/hw/timer/atmel_timer16.c @@ -0,0 +1,605 @@<snip>+ +/* Helper macros */ +#define VAL16(l, h) ((h << 8) | l) +#define DB_PRINT(fmt, args...) /* Nothing */ +/*#define DB_PRINT(fmt, args...) printf("%s: " fmt "\n", __func__, ## args)*/Format strings are likely to bitrot. Either use a if (GATE) or tracepoints.
To avoid respining, I'll do in a new a patch on top of this series, and Richard can choose to squash it directly.
<snip> Otherwise: Reviewed-by: Alex Bennée <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |