[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] include: Don't include qemu/osdep.h
From: |
Bin Meng |
Subject: |
Re: [PATCH] include: Don't include qemu/osdep.h |
Date: |
Mon, 12 Dec 2022 18:25:29 +0800 |
On Mon, Dec 12, 2022 at 3:05 PM Markus Armbruster <armbru@redhat.com> wrote:
>
> docs/devel/style.rst mandates:
>
> The "qemu/osdep.h" header contains preprocessor macros that affect
> the behavior of core system headers like <stdint.h>. It must be
> the first include so that core system headers included by external
> libraries get the preprocessor macros that QEMU depends on.
>
> Do not include "qemu/osdep.h" from header files since the .c file
> will have already included it.
>
> A few violations have crept in. Fix them.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> bsd-user/qemu.h | 1 -
> crypto/block-luks-priv.h | 1 -
> include/hw/cxl/cxl_host.h | 1 -
> include/hw/input/pl050.h | 1 -
> include/hw/tricore/triboard.h | 1 -
> include/qemu/userfaultfd.h | 1 -
> net/vmnet_int.h | 1 -
> qga/cutils.h | 1 -
> target/hexagon/hex_arch_types.h | 1 -
> target/hexagon/mmvec/macros.h | 1 -
> target/riscv/pmu.h | 1 -
> qga/cutils.c | 3 ++-
> 12 files changed, 2 insertions(+), 12 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>