|
From: | Richard Henderson |
Subject: | Re: [PATCH 02/10] target/hexagon: Declare hexagon_regnames[] in "cpu.h" |
Date: | Fri, 16 Dec 2022 16:33:07 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 |
On 12/16/22 14:05, Philippe Mathieu-Daudé wrote:
The hexagon_regnames array has TOTAL_PER_THREAD_REGS elements. TOTAL_PER_THREAD_REGS is defined in "cpu.h". Instead of pulling "cpu.h" in "internal.h", move the hexagon_regnames[] declaration to "cpu.h".
I don't think this is correct.I would have expected cpu.h to already be included by all users of internal.h, thus any formal re-inclusion of cpu.h at the top of internal.h should be a no-op.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |