[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/10] tests/avocado: add RISC-V opensbi boot test
From: |
Bin Meng |
Subject: |
Re: [PATCH v3 01/10] tests/avocado: add RISC-V opensbi boot test |
Date: |
Wed, 28 Dec 2022 23:18:33 +0800 |
On Wed, Dec 28, 2022 at 9:38 PM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> This test is used to do a quick sanity check to ensure that we're able
> to run the existing QEMU FW image.
>
> 'sifive_u', 'spike' and 'virt' riscv64 machines, and 'sifive_u' and
> 'virt' 32 bit machines are able to run the default RISCV64_BIOS_BIN |
> RISCV32_BIOS_BIN firmware with minimal options.
>
> The riscv32 'spike' machine isn't bootable at this moment, requiring an
> Opensbi fix [1] and QEMU side changes [2]. We could just leave at that
nits: OpenSBI
> or add a 'skip' test to remind us about it. To work as a reminder that
> we have a riscv32 'spike' test that should be enabled as soon as Opensbi
ditto
> QEMU rom receives the fix, we're adding a 'skip' test:
>
> (11/18) tests/avocado/riscv_opensbi.py:RiscvOpensbi.test_riscv32_spike:
> SKIP: requires OpenSBI fix to work
>
> [1]
> https://patchwork.ozlabs.org/project/opensbi/patch/20221226033603.1860569-1-bmeng@tinylab.org/
> [2] https://patchwork.ozlabs.org/project/qemu-devel/list/?series=334159
>
> Cc: Cleber Rosa <crosa@redhat.com>
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> ---
> tests/avocado/riscv_opensbi.py | 65 ++++++++++++++++++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 tests/avocado/riscv_opensbi.py
>
> diff --git a/tests/avocado/riscv_opensbi.py b/tests/avocado/riscv_opensbi.py
> new file mode 100644
> index 0000000000..3549d36a11
> --- /dev/null
> +++ b/tests/avocado/riscv_opensbi.py
> @@ -0,0 +1,65 @@
> +# OpenSBI boot test for RISC-V machines
> +#
> +# Copyright (c) 2022, Ventana Micro
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2 or
> +# later. See the COPYING file in the top-level directory.
> +
> +from avocado_qemu import QemuSystemTest
> +from avocado import skip
> +from avocado_qemu import wait_for_console_pattern
> +
> +class RiscvOpensbi(QemuSystemTest):
> + """
> + :avocado: tags=accel:tcg
> + """
> + timeout = 5
> +
> + def boot_opensbi(self):
> + self.vm.set_console()
> + self.vm.launch()
> + wait_for_console_pattern(self, 'Platform Name')
> + wait_for_console_pattern(self, 'Boot HART MEDELEG')
> +
> + def test_riscv64_virt(self):
> + """
> + :avocado: tags=arch:riscv64
> + :avocado: tags=machine:virt
> + """
> + self.boot_opensbi()
> +
> + def test_riscv64_spike(self):
> + """
> + :avocado: tags=arch:riscv64
> + :avocado: tags=machine:spike
> + """
> + self.boot_opensbi()
> +
> + def test_riscv64_sifive_u(self):
> + """
> + :avocado: tags=arch:riscv64
> + :avocado: tags=machine:sifive_u
> + """
> + self.boot_opensbi()
nits: could we keep both 64-bit and 32-bit machines in the same order?
e.g.: virt, sifive_u, spike
> +
> + def test_riscv32_virt(self):
> + """
> + :avocado: tags=arch:riscv32
> + :avocado: tags=machine:virt
> + """
> + self.boot_opensbi()
> +
> + def test_riscv32_sifive_u(self):
> + """
> + :avocado: tags=arch:riscv32
> + :avocado: tags=machine:sifive_u
> + """
> + self.boot_opensbi()
> +
> + @skip("requires OpenSBI fix to work")
> + def test_riscv32_spike(self):
> + """
> + :avocado: tags=arch:riscv32
> + :avocado: tags=machine:spike
> + """
> + self.boot_opensbi()
> --
Otherwise,
Reviewed-by: Bin Meng <bmeng@tinylab.org>
Tested-by: Bin Meng <bmeng@tinylab.org>
- [PATCH v3 00/10] irscv: OpenSBI boot test and cleanups, Daniel Henrique Barboza, 2022/12/28
- [PATCH v3 02/10] hw/riscv/spike: use 'fdt' from MachineState, Daniel Henrique Barboza, 2022/12/28
- [PATCH v3 04/10] hw/riscv/spike.c: load initrd right after riscv_load_kernel(), Daniel Henrique Barboza, 2022/12/28
- [PATCH v3 03/10] hw/riscv/sifive_u: use 'fdt' from MachineState, Daniel Henrique Barboza, 2022/12/28
- [PATCH v3 05/10] hw/riscv: write initrd 'chosen' FDT inside riscv_load_initrd(), Daniel Henrique Barboza, 2022/12/28
- [PATCH v3 06/10] hw/riscv: write bootargs 'chosen' FDT after riscv_load_kernel(), Daniel Henrique Barboza, 2022/12/28
- [PATCH v3 07/10] hw/riscv/boot.c: use MachineState in riscv_load_initrd(), Daniel Henrique Barboza, 2022/12/28