[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 10/11] target/riscv: remove RISCV_FEATURE_MMU
From: |
Bin Meng |
Subject: |
Re: [PATCH v2 10/11] target/riscv: remove RISCV_FEATURE_MMU |
Date: |
Wed, 15 Feb 2023 19:22:55 +0800 |
On Wed, Feb 15, 2023 at 3:27 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> RISCV_FEATURE_MMU is set whether cpu->cfg.mmu is set, so let's just use
> the flag directly instead.
>
> With this change the enum is also removed. It is worth noticing that
> this enum, and all the RISCV_FEATURES_* that were contained in it,
> predates the existence of the cpu->cfg object. Today, using cpu->cfg is
> an easier way to retrieve all the features and extensions enabled in the
> hart.
>
> Reviewed-by: Weiwei Li <liweiwei@iscas.ac.cn>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> ---
> target/riscv/cpu.c | 4 ----
> target/riscv/cpu.h | 7 -------
> target/riscv/cpu_helper.c | 2 +-
> target/riscv/csr.c | 4 ++--
> target/riscv/monitor.c | 2 +-
> target/riscv/pmp.c | 2 +-
> 6 files changed, 5 insertions(+), 16 deletions(-)
>
Reviewed-by: Bin Meng <bmeng@tinylab.org>
- Re: [PATCH v2 05/11] target/riscv: remove RISCV_FEATURE_DEBUG, (continued)
- [PATCH v2 06/11] target/riscv/cpu.c: error out if EPMP is enabled without PMP, Daniel Henrique Barboza, 2023/02/14
- [PATCH v2 07/11] target/riscv: remove RISCV_FEATURE_EPMP, Daniel Henrique Barboza, 2023/02/14
- [PATCH v2 08/11] target/riscv: remove RISCV_FEATURE_PMP, Daniel Henrique Barboza, 2023/02/14
- [PATCH v2 09/11] hw/riscv/virt.c: do not use RISCV_FEATURE_MMU in create_fdt_socket_cpus(), Daniel Henrique Barboza, 2023/02/14
- [PATCH v2 10/11] target/riscv: remove RISCV_FEATURE_MMU, Daniel Henrique Barboza, 2023/02/14
- Re: [PATCH v2 10/11] target/riscv: remove RISCV_FEATURE_MMU,
Bin Meng <=
- [PATCH v2 11/11] target/riscv/cpu: remove CPUArchState::features and friends, Daniel Henrique Barboza, 2023/02/14
- Re: [PATCH v2 00/11] enable write_misa() and RISCV_FEATURE_* cleanups, Andrew Jones, 2023/02/15