Re: [PATCH v4 4/4] target/riscv: Apply modularized matching conditions for icount trigger

[Alistair Francis]

On Tue, Feb 27, 2024 at 11:25 AM Alvin Chang via <qemu-devel@nongnu.org> wrote:
>
> We have implemented trigger_common_match(), which checks if the enabled
> privilege levels of the trigger match CPU's current privilege level. We
> can invoke trigger_common_match() to check the privilege levels of the
> type 3 triggers.
>
> Signed-off-by: Alvin Chang <alvinga@andestech.com>

Acked-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  target/riscv/debug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/debug.c b/target/riscv/debug.c
> index 9f9f332019..eb45e2c147 100644
> --- a/target/riscv/debug.c
> +++ b/target/riscv/debug.c
> @@ -624,7 +624,7 @@ void helper_itrigger_match(CPURISCVState *env)
>          if (get_trigger_type(env, i) != TRIGGER_TYPE_INST_CNT) {
>              continue;
>          }
> -        if (check_itrigger_priv(env, i)) {
> +        if (!trigger_common_match(env, TRIGGER_TYPE_INST_CNT, i)) {
>              continue;
>          }
>          count = itrigger_get_count(env, i);
> --
> 2.34.1
>
>