Re: [PATCH v2 3/8] hw/riscv/virt.c: rename aplic nodename to 'interrupt-controller'

[Alistair Francis]

On Sat, Jun 1, 2024 at 6:30 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> The correct name of the aplic controller node, as per Linux kernel DT
> docs [1], is 'interrupt-controller@addr'.
>
> [1] Documentation/devicetree/bindings/interrupt-controller/riscv,aplic.yaml
>
> Reported-by: Conor Dooley <conor@kernel.org>
> Fixes: e6faee65855b ("hw/riscv: virt: Add optional AIA APLIC support to virt 
> machine")
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  hw/riscv/virt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
> index 07a07f5ce1..5505047945 100644
> --- a/hw/riscv/virt.c
> +++ b/hw/riscv/virt.c
> @@ -591,7 +591,7 @@ static void create_fdt_imsic(RISCVVirtState *s, const 
> MemMapEntry *memmap,
>  /* Caller must free string after use */
>  static char *fdt_get_aplic_nodename(unsigned long aplic_addr)
>  {
> -    return g_strdup_printf("/soc/aplic@%lx", aplic_addr);
> +    return g_strdup_printf("/soc/interrupt-controller@%lx", aplic_addr);
>  }
>
>  static void create_fdt_one_aplic(RISCVVirtState *s, int socket,
> --
> 2.45.1
>
>