Re: [PATCH v3 2/7] target/riscv: Adjust PMP size for no-MMU RV64 QEMU ru

qemu-riscv

From:	Richard Henderson
Subject:	Re: [PATCH v3 2/7] target/riscv: Adjust PMP size for no-MMU RV64 QEMU running RV32
Date:	Wed, 3 Jul 2024 09:48:15 -0700
User-agent:	Mozilla Thunderbird

On 7/3/24 07:49, LIU Zhiwei wrote:

-            pmp_size = sizeof(target_ulong);
+            pmp_size = 2UL << riscv_cpu_mxl(env);


UL is almost always incorrect in qemu, as 'long' has no specifically useful 
meaning.

In this case you can drop it completely.


r~

Current Thread

[Next in Thread]

[PATCH v3 0/7] target/riscv: Expose RV32 cpu to RV64 QEMU, LIU Zhiwei, 2024/07/03
- [PATCH v3 1/7] target/riscv: Add fw_dynamic_info32 for booting RV32 OpenSBI, LIU Zhiwei, 2024/07/03
- [PATCH v3 2/7] target/riscv: Adjust PMP size for no-MMU RV64 QEMU running RV32, LIU Zhiwei, 2024/07/03
  - Re: [PATCH v3 2/7] target/riscv: Adjust PMP size for no-MMU RV64 QEMU running RV32, Richard Henderson <=
- [PATCH v3 3/7] target/riscv: Correct SXL return value for RV32 in RV64 QEMU, LIU Zhiwei, 2024/07/03
- [PATCH v3 4/7] target/riscv: Detect sxl to set bit width for RV32 in RV64, LIU Zhiwei, 2024/07/03
- [PATCH v3 5/7] target/riscv: Correct mcause/scause bit width for RV32 in RV64 QEMU, LIU Zhiwei, 2024/07/03
  - Re: [PATCH v3 5/7] target/riscv: Correct mcause/scause bit width for RV32 in RV64 QEMU, Richard Henderson, 2024/07/03
- [PATCH v3 6/7] target/riscv: Enable RV32 CPU support in RV64 QEMU, LIU Zhiwei, 2024/07/03
- [PATCH v3 7/7] tests/avocado: Add an avocado test for riscv64, LIU Zhiwei, 2024/07/03