Re: [PATCH 2/5] hw/char/serial: Remove unused funtion

[Mark Cave-Ayland]

On 14/08/2024 22:38, BALATON Zoltan wrote:

> On Wed, 14 Aug 2024, Bernhard Beschow wrote:
> > The serial port's frequency is set via the "baudbase" property nowadays.
>
> Please keep it as some devices might have registers that set this freq and this 
> function will be needed for emulating that even if it's not emulated currently.

Why not remove the function if it isn't being used? In general having unused code 
lying around is bad as it tends to bitrot.

If someone did want to re-add this functionality then you would likely want to do it 
with clock API rather than using a separate function.


ATB,

Mark.