Re: [PATCH for-9.2 02/10] target/s390: Convert CPU to Resettable interface

[Thomas Huth]

On 14/08/2024 01.03, Richard Henderson wrote:
> On 8/14/24 02:52, Peter Maydell wrote:
> >   static void sigp_cpu_reset(CPUState *cs, run_on_cpu_data arg)
> >   {
> > -    S390CPU *cpu = S390_CPU(cs);
> > -    S390CPUClass *scc = S390_CPU_GET_CLASS(cpu);
> >       SigpInfo *si = arg.host_ptr;
> >       cpu_synchronize_state(cs);
> > -    scc->reset(cs, S390_CPU_RESET_NORMAL);
> > +    resettable_reset(OBJECT(cs), RESET_TYPE_COLD);
>
> NORMAL, not COLD here?
>
> Otherwise,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

With that fixed:
Acked-by: Thomas Huth <thuth@redhat.com>