Re: [PATCH for-9.2 01/10] hw/s390/virtio-ccw: Convert to three-phase reset

[Peter Maydell]

On Mon, 26 Aug 2024 at 17:02, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Hi Peter,
>
> On 13/8/24 18:52, Peter Maydell wrote:
> > Convert the virtio-ccw code to three-phase reset.  This allows us to
> > remove a call to device_class_set_parent_reset(), replacing it with
> > the three-phase equivalent resettable_class_set_parent_phases().
> > Removing all the device_class_set_parent_reset() uses will allow us
> > to remove some of the glue code that interworks between three-phase
> > and legacy reset.
> >
> > This is a simple conversion, with no behavioural changes.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> > It looks a little odd that we do the this-class reset first
> > and then chain up to the parent's reset, but that's what the
> > existing code does, so I left it alone.
>
> Do you plan to post a follow up patch inverting the
> call order? Otherwise, could you add a comment in the
> code so we don't forget about this odd case?

I didn't plan to do either because I don't know whether
the s390 code relies on this or not and I don't want
to investigate either... If somebody on the s390 side
is interested in tracking that down they're welcome to :-)

-- PMM