qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-9.2 00/10] s390: Convert virtio-ccw, cpu to three-phase r


From: Nina Schoetterl-Glausch
Subject: Re: [PATCH for-9.2 00/10] s390: Convert virtio-ccw, cpu to three-phase reset, and followup cleanup
Date: Thu, 22 Aug 2024 12:34:14 +0200
User-agent: Evolution 3.52.3 (3.52.3-1.fc40)

On Wed, 2024-08-14 at 21:06 +0100, Peter Maydell wrote:
> On Wed, 14 Aug 2024 at 15:22, Christian Borntraeger
> <borntraeger@linux.ibm.com> wrote:
> > 
> > Am 13.08.24 um 18:52 schrieb Peter Maydell:
> > > The main aim of this patchseries is to remove the two remaining uses
> > > of device_class_set_parent_reset() in the tree, which are virtio-ccw
> > > and the s390 CPU class. Doing that lets us do some followup cleanup.
> > > (The diffstat looks alarming but is almost all coccinelle automated
> > > changes.)
> > > 
> > > Note that my testing here has only been "make check" and
> > > "make check-avocado", which I know doesn't really exercise reset
> > > very heavily.
> 
> > Nina, can you have a look at those patches?
> 
> If you plan to do any testing you'll want to locally fix the
> silly mistake I made in patch 2 (a RESET_TYPE_COLD where
> it should say RESET_TYPE_S390_CPU_NORMAL) -- see the review
> comments on that patch. Sorry about that one...
> 
> thanks
> -- PMM
> 

I'll run it through our CI and see if anything pops up.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]