[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Quilt-dev] dirname
From: |
John Vandenberg |
Subject: |
[Quilt-dev] dirname |
Date: |
Tue, 23 May 2006 23:40:31 +1000 |
Hi,
In order to workaround the msys bug [1] [2], Andreas suggested that
msys users could set QUILT_PC to ".pc/" instead of ".pc". This works
well except in fold, where mkdir (line 95) does the wrong thing when
the dirname removes all consecutive slashes [3], resulting in a path
like .pcpatch1.diff/dir instead of .pc/patch1.diff/dir. Backing that
patch out fixes this problem, but I suspect more changes are required
before dirname does the right thing.
As an aside, dirname isn't heavily used, or used in a performance
critical loop (afaics) -- running the entire test suite invokes it 148
times. Is it worth keeping in patchfns ? If it exist for
compatibility reasons, can I write a few tests and move it to
compat/dirname.in?
1. http://lists.zerezo.com/mingw-msys/msg00525.html
2. http://zeroj.hda0.net/quilt/patches/msys-sh-wierd-bug.diff
3.
http://cvs.sv.nongnu.org/viewcvs/quilt/quilt/scripts/Attic/patchfns.in?r1=1.9&r2=1.10
--
John
- [Quilt-dev] dirname,
John Vandenberg <=