[sr #110738] configure gets confused with a build dir with the same base name as the current project

[Boud Roukema]

Follow-up Comment #6, sr #110738 (project reproduce):

REMOVAL OF SUBDIRECTORY:

"Another thing: even if the regex fails, the directory is removed (if exists).
I don't think any existing directory should be removed without user
confirmation."

Maneage has quite a few 'rm' statements - see
https://savannah.nongnu.org/task/?15997 for a related task that could reduce
the probability of bad 'rm's occurring. And 'makefiles' typically have
non-interactive removes with 'make clean' or with some steps in build
processes (to remove temporary build directories).

Arguments for retaining the deletion section:
* In this particular case, the subdirectory is only deleted if it appears to
be empty (per 'ls -A').
* The user should expect Maneage to be responsible for files and directories
within its source directory, so deletion of an extra directory inserted there
should be acceptable.

Arguments for making the deletion interactive (possibly by default disabled):
* The user might wish to add some files and directories with the Maneage
source directory, and even if a directory is empty, might still be annoyed at
having it be deleted.
* A user could still use '< /dev/null' for remaining inputs and fall back to a
default, without being forced to run ./project interactively.

There seem to be arguments both ways. This could possibly be split off as a
separate bug or task.


SYMLINK DIRECTORY(IES):

A separate issue is that the current subdirectory test does not check all
cases of subdirectoriness. E.g.

cd /home/user
ln -s mysymlink myproj
cd mysymlink
mkdir buildsubdir

In this case, _/home/user/myproj/buildsubdir_ is in reality a subdirectory of
_/home/user/mysymlink_, but 'configure.sh' will not detect that, since it only
compares absolute paths (obtained with 'pwd' from the host OS), not
dereferenced absolute paths.

This could as much be a feature as a bug :), but someone could split it off as
a bug or task if s/he feels that it's worth handling in the long term.




    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/support/?110738>

_______________________________________________
Message sent via Savannah
https://savannah.nongnu.org/