tramp-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tramp-cache and destructive operations


From: Jürgen Hötzel
Subject: Re: tramp-cache and destructive operations
Date: Fri, 14 Aug 2015 22:09:21 +0200

Hi Michael,

On Fri, Aug 14, 2015 at 9:31 PM, Michael Albinus <address@hidden> wrote:
Jürgen Hötzel <address@hidden> writes:

> Hi Michael

Hi Juergen,

>     Consequently, you must also flush the file properties of the
>     directory, if you call `tramp-adb-handle-set-file-modes' or
>     `tramp-adb-handle-set-file-times'.
>
> Good catch: There was the same issue in
> `tramp-sh-handle-set-file-modes' and
> `tramp-sh-handle-set-file-times'.

Yep. I'm not 100% sure that it was necessary for
 `tramp-sh-handle-set-file-modes' and `tramp-sh-handle-set-file-times',
because tramp-sh doesn't cache file attributes of the files in the
directory.

Yes, i checked it out. The "directory-files-and-attributes-string" property of the the directory was stale alfter setting the file-times or -modes.

But it doesn't hurt, so it's OK.

I have changed your patch a little bit, see the ChangeLog.


Thanks: Again good catch.
 
Btw, good you pls apply the rules for ChangeLog entries? Minor points,
like a sentence finishes with a period, and there are two spaces between
sentences. See the fixes I have applied in ChangeLog.

Yep. Sorry.

Regards, Jürgen


reply via email to

[Prev in Thread] Current Thread [Next in Thread]