[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: wget2 | Draft: Small fixes (!505)
From: |
Avinash Sonawane (@rootkea) |
Subject: |
Re: wget2 | Draft: Small fixes (!505) |
Date: |
Sat, 25 Jun 2022 17:32:35 +0000 |
Avinash Sonawane commented on a discussion on libwget/buffer.c:
https://gitlab.com/gnuwget/wget2/-/merge_requests/505#note_1005439488
> */
> size_t wget_buffer_memset(wget_buffer *buf, char c, size_t length)
> {
> - if (likely(buf))
> + if (likely(buf) && length)
Yeah, I have some more thoughts on buffer.c but haven't compiled them properly
yet. And that's why haven't replied to those comments yet. :)
Anyways, I am going to remove buffer.c commits from this MR and will open a new
MR to discuss buffer API.
--
Reply to this email directly or view it on GitLab:
https://gitlab.com/gnuwget/wget2/-/merge_requests/505#note_1005439488
You're receiving this email because of your account on gitlab.com.
- Re: wget2 | Draft: Small fixes (!505), (continued)
- Re: wget2 | Draft: Small fixes (!505), Avinash Sonawane (@rootkea), 2022/06/07
- Re: wget2 | Draft: Small fixes (!505), Avinash Sonawane (@rootkea), 2022/06/22
- Re: wget2 | Draft: Small fixes (!505), Avinash Sonawane (@rootkea), 2022/06/23
- Re: wget2 | Draft: Small fixes (!505), @rockdaboot, 2022/06/25
- Re: wget2 | Draft: Small fixes (!505), Avinash Sonawane (@rootkea), 2022/06/25
- Re: wget2 | Draft: Small fixes (!505), @rockdaboot, 2022/06/25
- Re: wget2 | Draft: Small fixes (!505), @rockdaboot, 2022/06/25
- Re: wget2 | Draft: Small fixes (!505),
Avinash Sonawane (@rootkea) <=
- Re: wget2 | Draft: Small fixes (!505), @rockdaboot, 2022/06/25
- Re: wget2 | Draft: Small fixes (!505), @rockdaboot, 2022/06/26
- Re: wget2 | Draft: Small fixes (!505), @rockdaboot, 2022/06/26