Re: [Automake-NG] [PATCH 10/26] [ng] texi: reduce code duplication in output Makefile

[Akim Demaille]

Le 16 juin 2012 à 23:29, Stefano Lattarini a écrit :

> diff --git a/lib/am/texibuild.am b/lib/am/texibuild.am
> index a81bcf2..09905d5 100644
> --- a/lib/am/texibuild.am
> +++ b/lib/am/texibuild.am
> @@ -89,14 +89,15 @@ define am__texibuild_html
>       fi
> endef
> 
> -%.info: %.%TEXI-SUFFIX%
> -     $(call am__texibuild_info,$(am__info_insrc))
> -
> -%.dvi: %.%TEXI-SUFFIX%
> -     $(call am__texibuild_dvi_or_pdf,%AM_V_TEXI2DVI%,$(TEXI2DVI))
> -
> -%.pdf: %.%TEXI-SUFFIX%
> -     $(call am__texibuild_dvi_or_pdf,%AM_V_TEXI2PDF%,$(TEXI2PDF))
> +define am__texi_rules_for_suffix
> +%.info: %.$1
> +     $$(call am__texibuild_info,$$(am__info_insrc))
> +%.dvi: %.$1
> +     $$(call am__texibuild_dvi_or_pdf,$$(AM_V_TEXI2DVI),$$(TEXI2DVI))
> +%.pdf: %.$1
> +     $$(call am__texibuild_dvi_or_pdf,$$(AM_V_TEXI2PDF),$$(TEXI2PDF))
> +%.html: %.$1
> +     $$(am__texibuild_html)
> +endef
> 
> -%.html: %.%TEXI-SUFFIX%
> -     $(am__texibuild_html)
> +$(foreach s,%TEXI-SUFFIXES%,$(eval $(call am__texi_rules_for_suffix,$s)))

This kind of changes will make using "grep" in the Makefile, to find
the recipes, less obvious.  I think I prefer the previous approach.