Re: [Automake-NG] [PATCH 08/26] [ng] texi: reduce code duplication in texibuild.am

[Stefano Lattarini]

On 06/17/2012 08:52 AM, Akim Demaille wrote:
> 
> Le 16 juin 2012 à 23:29, Stefano Lattarini a écrit :
> 
>> +define am__texibuild_dvi_or_pdf
>> +    $1$(am__ensure_target_dir_exists) && \
>> +    TEXINPUTS="$(am__TEXINFO_TEX_DIR)$(PATH_SEPARATOR)$$TEXINPUTS" \
>> +## Must set MAKEINFO like this so that version.texi will be found even
>> +## if it is in srcdir (-I $(srcdir) is set in '$(am__makeinfoflags)').
>> +    MAKEINFO='$(MAKEINFO) $(AM_MAKEINFOFLAGS) $(MAKEINFOFLAGS) 
>> $(am__makeinfoflags)' \
>> +## texi2dvi and texi2pdf don't silence everything with -q, redirect to
>> +## /dev/null instead.
>> +## We still want -q (%TEXIQUIET%) because it turns on batch mode.
>> +## Use '--clean' to avoid leaving auxiliary files behind cluttering the
>> +## build directory (see automake bug#11146).  We should start using
>> +## '--tidy' when we can assume Texinf 4.9 or later.
>> +    $2 %TEXIQUIET% --clean -o $@ $< %TEXIDEVNULL%
>> +endef
> 
> Is it on purpose that you keep it tab-indented?
>
Yes: it makes it clearer that the output of this function is expected to be
used in Makefile recipes.

Also, while I generally dislike indentation with tabs in most languages,
they are not such a big deal fro Makefiles IMHO, since there you are
*forced* to use tabs anyway (when writing recipes) ...

Regards,
  Stefano