Re: 02-distclean-test.diff

[Derek Robert Price]

Alexandre Duret-Lutz wrote:

> Derek> One last question, why is only the last $where preserved
> Derek> for AC_CONFIG_FILES and the like?  
>
> I can't think of any reason, unless all that code was copied
> from AC_CONFIG_HEADER which never really supported more than one
> header (due to the rebuild rules that call autoheader, IIRC).

Okay.  I'll see about fixing that soon.

> Derek> I duplicated this behavior for AC_CONFIG_LINKS, but it
> Derek> doesn't seem like it would be very hard to preserve the
> Derek> exact $where for each macro invocation.
>
> Indeed.
>
>
> [...]
>
> Derek> +cat >>configure.in << 'EOF'
> Derek> +AM_INIT_AUTOMAKE
>
> You shouldn't need this one: it's already in configure.in.

Hrm.  You're correct.  I removed it and everything still worked.  In one 
of my test runs automake was complaining that it hadn't been added and I 
added it.  Maybe I was overwriting configure.in at the time?  I didn't 
think so...

> Better put `set -e' directly after ./defs || exit 1.  Even the
> echo/mkdir/:/cat can fail.

Done.

> [...]
>
> Derek> +set +e
>
> I think this is not needed either.  `false && exit 1' is
> perfectly safe with `set -e'.  

Removed.

> Derek> +test -r dest && exit 1
> Derek> +test -r dest2 && exit 1
> Derek> +test -r sdir/dest && exit 1
> Derek> +test -r dest3 && exit 1
> Derek> +test -r sdir/dest2 && exit 1
> Derek> +test -r sdir-no-make/dest && exit 1
>
> I'm surprised this succeeds.  When sdir-no-make/dest does not
> exist (which is expected), this last line should return with $?
> = 1.  At least that's how it works with all the shell I've tried
>  

Again, you were correct.  I was running the test from the shell and not 
through make and had decided it must be passing since every command had 
been executed.  I fixed it to exit correctly and ran the whole suite, 
which passes except for the 15 tests that were failing for a clean checkout.

I'll include the new patch shortly, after I try and get the require 
error messages correct.

Derek

--
               *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
--
The price of freedom is eternal vigilance.

                        - Thomas Jefferson