Re: 02-distclean-test.diff

[Derek Robert Price]

Alexandre Duret-Lutz wrote:

> I'm happy with the implementation of the patch, but since this
> is a new feature there are two more things that I'd like to see
> committed at the same time: a mention in ./NEWS, and another one
> in the manual (at least in the "Other things Automake
> recognizes" section).  Consider that virtual augmented patch
> approved.

See below.  Also, do you prefer prepended NEWS, appended NEWS, or does 
new NEWS just go wherever it looks best?

> Derek> * tests/Makefile.am (XFAIL_TESTS): Add new tests.
>
> I hope not :)

Whoops.  Nope.  Just forgot to update the ChangeLog.  :)

> Derek> (TESTS): Ditto.
> Derek> * tests/distclean.test: New test that links are cleaned on distclean.
> Derek> * tests/distlinksource.test: New test that source files for links are
> Derek> distributed.
>
> Since these are both checking the support for AC_CONFIG_LINK,
> how about renaming them to something like conflnk.test and
> conflnk2.test?  That will leave room for future tests about
> the same feature without hurting DJGPP with long filenames.
>  

Done.  I won't bother to include the patch until I commit it.

        * NEWS: Note new handling of AC_CONFIG_LINKS.
        * automake.texi (Other things Automake recognizes): Ditto.

Index: NEWS
===================================================================
RCS file: /cvs/automake/automake/NEWS,v
retrieving revision 1.218
diff -u -r1.218 NEWS
--- NEWS        20 Jun 2003 19:12:31 -0000      1.218
+++ NEWS        27 Jun 2003 03:27:29 -0000
@@ -125,6 +125,9 @@

* Targets dist-gzip, dist-bzip2, dist-tarZ, dist-zip are always defined.

+* Automake will now recognize AC_CONFIG_LINKS so far as removing created links
+  as part of the distclean target and including source files in distributions.
+

New in 1.7:
* Autoconf 2.54 is required.
Index: automake.texi
===================================================================
RCS file: /cvs/automake/automake/automake.texi,v
retrieving revision 1.341
diff -u -r1.341 automake.texi
--- automake.texi       25 Jun 2003 14:01:22 -0000      1.341
+++ automake.texi       27 Jun 2003 03:27:32 -0000
@@ -1144,6 +1144,12 @@
(@pxref{Macros}); this is no longer the case today.
@cvindex AC_CONFIG_HEADERS

address@hidden AC_CONFIG_LINKS
+Automake will generate rules to remove @file{configure} generated links on
address@hidden distclean} and to distribute named source files as part of
address@hidden dist}.
address@hidden AC_CONFIG_LINKS
+
@item AC_CONFIG_AUX_DIR
Automake will look for various helper scripts, such as
@file{mkinstalldirs}, in the directory named in this macro invocation.



Derek

--
               *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
--
Suburbia:  Where they tear out the trees and name the streets after them.