bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Renaming muscles


From: Tim Van Holder
Subject: Re: Renaming muscles
Date: Wed, 3 Jul 2002 20:30:24 +0200

> Index: ChangeLog
> from  Akim Demaille  <address@hidden>
> 
>       * src/output.c (froms, tos): Are state_number_t.
>       (save_column): sp, sp1, and sp2 are state_number_t.
>       (prepare): Rename `final' as `final_state_number', `nnts' as
>       `nterms_number', `nrules' as `rules_number', `nstates' as
>       `states_number', and `ntokens' as `tokens_number'.  
> Remove `nsym',
>       unused.
>       * data/yacc.c, data/glr.c, data/lalr1.cc: Adjust.
>       * data/lalr1.cc (nsym_): Remove, unused.

>From the old names, I'm assuming nrules is the number of rules.
As such, rules_number is not that great a name (in English); it
should either be number_of_rules, or rule_count (and the latter is
more typically used).  Similar for the others - use <singular>_count
instead of <plural>_number.
A bit of nitpicking, but rules_number I would find harder to
immediately grasp than nrules (as the n prefix is typically used for
counts).




reply via email to

[Prev in Thread] Current Thread [Next in Thread]