bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Renaming muscles


From: Tim Van Holder
Subject: Re: Renaming muscles
Date: Fri, 12 Jul 2002 22:05:33 +0200

Sorry for the delay

> Hm.  So really, states_number is wrong?  Well, you have the final
> call:
> 
>         - nstates

This is good, but the whole point was to renamed this to get a clearer
name, wasn't it :-)

>         - number_of_states

This is clear and correct, but is a bit verbose.  Second choice.

>         - states_number_of

This is a bit of a twisted way of writing the above - not good.
Source code shouldn't read like a book's index :-)

>         - states_number

This is less clear than nstates - not good.

>         - state_count

This is clear and not overly long - first choice.


Up to you to use state_count or number_of_states - they are both
very clear.  Besides, as maintainer you'll have to use them more
than I, a simple mailing list lurker :-)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]