Re: [Bug-freedink] Screen or Sprites Flickering

[beuc]

Hi,

On Mon, Mar 20, 2017 at 12:43:57AM -0700, Eric Duhamel wrote:
> On March 19, 2017 3:49:45 PM PDT, address@hidden wrote:
> >Let me know if the patch works for you.
> 
> Thank you for taking the time to write a patch. I apologize for the delay.
> 
> The changes compiled flawlessly --I applied them to release 108.4--
> and the flicker is now gone in framebuffer on my Raspberry Pi. I'm
> surprised it did work at all, since you said you had trouble with it
> on your Pi.

Incidentally it was an issue with the stock libc-dev (I think?) on
Raspian Wheezy.
apt-get upgrade fixed it.
Nothing to do with the patch anyway.


> However, everything is now in psychedelic colors. There must have
> been a graphics mode problem somewhere in the fix?

Ah, we forwarded the pixels but not the 8-bit palette.
The new attached patch should fix the problem.
Sadly SDL_SetPalette() clears the screen for some reason...
As a result the fade_down/fade_up effects (enter/exit a house) get flickering XD

Alternatively, you can use --truecolor to request a non-paletted video mode.
(In either case you can ditch the SDL_Flip() call since we're
 single-buffered  =>  better perfs.)
Also remember that all these hacks basically break X11 mode.

Thanks for testing!

Cheers!
Sylvain

rpihack-2.patch
Description: Text Data