[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHv2 3/9] getcwd: enhance tests
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCHv2 3/9] getcwd: enhance tests |
|
Date: |
Wed, 27 Apr 2011 18:09:27 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.9 |
On 04/27/2011 11:58 AM, Eric Blake wrote:
> On 04/26/2011 05:35 PM, Eric Blake wrote:
>> * tests/test-getcwd-lgpl.c: New file, taken from...
>> * tests/test-getcwd.c: ...old contents. Rewrite this file to
>> repeat long path stress tests from m4 probe.
>> * modules/getcwd-lgpl-tests: New module.
>> * modules/getcwd-tests (Depends-on): Depend on lgpl tests.
>> * m4/getcwd-abort-bug.m4: Update comment.
>> * m4/getcwd-path-max.m4: Likewise.
>
> I enhanced the test-getcwd-lgpl a bit more (ensure that whether buf is
> NULL or provided, that too-small but non-zero size results in ERANGE),
> then pushed this.
And in the process, found that mingw getcwd() is broken :)
mingw uses int instead of size_t for the second argument, and returns a
string rather than failing with ERANGE on getcwd(NULL, 1).
I'll have to fix that tomorrow.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [PATCHv2 4/9] save-cwd: reduce dependency, (continued)
- [PATCHv2 2/9] getcwd-lgpl: new module, Eric Blake, 2011/04/26
- [PATCHv2 5/9] dirent-safer: drop unused link dependency, Eric Blake, 2011/04/26
- [PATCHv2 6/9] tests: reduce dependencies, Eric Blake, 2011/04/26
- [PATCHv2 3/9] getcwd: enhance tests, Eric Blake, 2011/04/26
- [PATCHv2 7/9] linkat, renameat: add missing dependency, Eric Blake, 2011/04/26
- [PATCHv2 8/9] filenamecat-lgpl: fix licence, Eric Blake, 2011/04/26
- [PATCHv2 9/9] fchdir: avoid extra chdir and fix test, Eric Blake, 2011/04/26