Re: [bug-inetutils] Cleaning up warnings

[Debarshi Ray]

>>>  @@ -265,6 +265,7 @@ ls_main (argc, argv)
>>>    if (f_longform || f_size)
>>>      {
>>>   #ifdef ORIGINAL_SOURCE
>>>  +      int notused;
>>>        if (!kflag)
>>>         getbsize (&notused, &blocksize);
>>>   #else

>> If we don't use this, can we just change getbsize to not require it?

>  We cannot: it is a library function on BSD and Darwin. It raises another
>  question, though. Similar `ifdef ORIGINAL_SOURCE' conditional blocks are
>  scattered all across the code in libls, but ORIGINAL_SOURCE itself is
>  never defined. So, the question is: do we need them at all? Removing
>  them will certainly improve readability and, as it seems, won't hurt
>  functionality.

M-x vc-annotate tells me that all those ORIGINAL_SOURCEs were put in
by Alain. Maybe he can throw some light on it.

Happy hacking,
Debarshi
-- 
"From what we get, we can make a living; what we give, however, makes a life."
 -- Arthur Ashe