bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-inetutils] Cleaning up warnings


From: Alfred M. Szmidt
Subject: Re: [bug-inetutils] Cleaning up warnings
Date: Sat, 10 May 2008 11:36:39 -0400

   >>>  @@ -265,6 +265,7 @@ ls_main (argc, argv)
   >>>    if (f_longform || f_size)
   >>>      {
   >>>   #ifdef ORIGINAL_SOURCE
   >>>  +      int notused;
   >>>        if (!kflag)
   >>>         getbsize (&notused, &blocksize);
   >>>   #else

   >> If we don't use this, can we just change getbsize to not require it?

   >  We cannot: it is a library function on BSD and Darwin. It raises another
   >  question, though. Similar `ifdef ORIGINAL_SOURCE' conditional blocks are
   >  scattered all across the code in libls, but ORIGINAL_SOURCE itself is
   >  never defined. So, the question is: do we need them at all? Removing
   >  them will certainly improve readability and, as it seems, won't hurt
   >  functionality.

   M-x vc-annotate tells me that all those ORIGINAL_SOURCEs were put in
   by Alain. Maybe he can throw some light on it.

It is safe to remove that cruft.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]