[cp-patches] APPROVAL: Merge of java.lang.StringBuilder

[Andrew John Hughes]

Attached is a patch to merge java.lang.StringBuilder (thanks
to Tom Tromey) to HEAD.
One of the main reasons for doing so is that StringBuilder is
used in 1.5 compiler-generated concatenation (+) code.  For example,
I simply recompiled a Mauve testcase yesterday after adding a simple
debugging line.  I did so with ecj (by mistake, after working with the
generics branch) and it failed to run, even though all that was added
was a simple println containing string concatenation.  As Java compiles
to bytecode, downloading and running pre-compiled binaries is generally
more common than with code that compiles natively.  It also may be the
case that the user doesn't know how to re-compile.  Some quick tests show
that adding StringBuilder allows findbugs to run, whereas before it
failed due to this missing class.

Please note that I've added //FIX15 comments to the three methods which
implement the Appendable interface.  Co-variant return types is a language
feature of 1.5, which will remain in the generics branch.

For anyone not aware of the design of this class, it is basically a
version of StringBuffer without synchronization.

Changelog:

2004-12-18  Tom Tromey  <address@hidden>

        * java/lang/String.java (String(StringBuilder)): Rewrote.
        * java/lang/StringBuilder.java (shared): Removed.

2004-10-14  Tom Tromey  <address@hidden>

        * java/lang/StringBuilder.java (append): Typo fix; indentation
        fix.

2004-09-18  Tom Tromey  <address@hidden>

        * java/lang/annotation/Retention.java: Documented.
        * java/lang/annotation/RetentionPolicy.java: Documented.
        * java/lang/StringBuilder.java: Updated documentation.

2004-09-07  Tom Tromey  <address@hidden>

        * java/lang/StringBuilder.java: New file.

.
-- 
Andrew :-)

Please avoid sending me Microsoft Office (e.g. Word, PowerPoint) attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html

No software patents in Europe -- http://nosoftwarepatents.com

"Value your freedom, or you will lose it, teaches history. 
`Don't bother us with politics' respond those who don't want to learn." 
-- Richard Stallman

"We've all been part of the biggest beta test the world has ever known --
Windows" 
-- Victor Wheatman, Gartner

stringbuilder.diff
Description: Text document

signature.asc
Description: Digital signature