RE: [cp-patches] APPROVAL: Merge of java.lang.StringBuilder

[Andrew John Hughes]

On Wed, 2005-01-19 at 10:37, Jeroen Frijters wrote:
> Andrew John Hughes wrote:
> > On Wed, 2005-01-19 at 09:09, Jeroen Frijters wrote:
> > > Andrew John Hughes wrote:
> > > > Attached is a patch to merge java.lang.StringBuilder (thanks
> > > > to Tom Tromey) to HEAD.
> > > 
> > > I'm still not thrilled about this. If any of the //FIXME methods are
> > > used (in code compiled against the Sun libraries), it will still not
> > > work correctly.
> > > 
> > Well, I have no problem with removing those all together from the HEAD
> > patch; they are only for implementing the Appendable interface.
> 
> They might still be used. How about leaving the methods in (returning
> StringBuilder) and not implementing Appendable, that would seem to have
> the highest chance of not disrupting anything?
> 
> Regards,
> Jeroen

Of course; that's what causes the conflict... patch attached.
-- 
Andrew :-)

Please avoid sending me Microsoft Office (e.g. Word, PowerPoint) attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html

No software patents in Europe -- http://nosoftwarepatents.com

"Value your freedom, or you will lose it, teaches history.
`Don't bother us with politics' respond those who don't want to learn."
-- Richard Stallman

"We've all been part of the biggest beta test the world has ever known --
Windows"
-- Victor Wheatman, Gartner

stringbuilder.diff
Description: Text Data

signature.asc
Description: This is a digitally signed message part