RE: [cp-patches] APPROVAL: Merge of java.lang.StringBuilder

[Jeroen Frijters]

Andrew John Hughes wrote:
> On Wed, 2005-01-19 at 09:09, Jeroen Frijters wrote:
> > Andrew John Hughes wrote:
> > > Attached is a patch to merge java.lang.StringBuilder (thanks
> > > to Tom Tromey) to HEAD.
> > 
> > I'm still not thrilled about this. If any of the //FIXME methods are
> > used (in code compiled against the Sun libraries), it will still not
> > work correctly.
> > 
> Well, I have no problem with removing those all together from the HEAD
> patch; they are only for implementing the Appendable interface.

They might still be used. How about leaving the methods in (returning
StringBuilder) and not implementing Appendable, that would seem to have
the highest chance of not disrupting anything?

Regards,
Jeroen