RE: java.lang.Class patches

[Jeroen Frijters]

Hi,

I really like this change and I have a few comments:

- Please move forName(String) to VMClass, some VMs might be able to get
the caller's ClassLoader in a more efficient way.
- Same goes for isArray(), getting the class name can potentially be an
expensive operation.
- getSigners() should return a clone of the signers array.
- internalGetMethods() should not return overridden virtual methods
multiple times, see attached file for what I think is a correct
implementation

Regards,
Jeroen

> 
> -----Original Message-----
> From: Brian Jones [mailto:address@hidden 
> Sent: Thursday, April 03, 2003 07:38
> To: Archie Cobbs
> Cc: address@hidden
> 
> Archie Cobbs <address@hidden> writes:
> 
> > Below is a subset of my current set of diffs for java.lang.Class.
> > I'm sending them just for anyone to look at and for 
> consideration for 
> > checking in. I think some of them could be useful for classpath.
> > I'd be interested to hear what other people think.
> > 
> 
> I've made a few modifications by splitting out the native 
> methods into VMClass.  When committed I'll move Class.java to 
> classpath/java/lang/ and out of the vm/reference directory.  
> I've added gnu.classpath.RawData following gcj's lead in this 
> case.  I'm seeking comments before committing this patch 
> based on Archie's work.  Sorry I'm personally taking so long 
> with a lot of the patches submitted lately.
> 
> Thanks,
> Brian
> --
> Brian Jones <address@hidden>
> 
>

internalGetMethods.txt
Description: internalGetMethods.txt