classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: java.lang.Class patches


From: Brian Jones
Subject: Re: java.lang.Class patches
Date: 03 Apr 2003 21:18:36 -0500
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2

"Jeroen Frijters" <address@hidden> writes:

> Hi,
> 
> I really like this change and I have a few comments:
> 
> - Please move forName(String) to VMClass, some VMs might be able to get
> the caller's ClassLoader in a more efficient way.
> - Same goes for isArray(), getting the class name can potentially be an
> expensive operation.

For these I used the VMClass versions as simply ways a JVM could
indicate they wanted to do something special but it neither is
required to do much of anything.  Check javadoc for specifics.

> - getSigners() should return a clone of the signers array.

Used signers.clone().

> - internalGetMethods() should not return overridden virtual methods
> multiple times, see attached file for what I think is a correct
> implementation

Applied your patch, thanks.

Brian
-- 
Brian Jones <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]