Re: [Discuss-gnuradio] On config.h (was Check for gr-ctrlport)

[Tom Rondeau]

On Sun, Mar 31, 2013 at 3:46 AM, Sylvain Munaut <address@hidden> wrote:
> Hi,
>
>> Does anyone else have strong opinions on this subject? Or will the
>> path to using the <gnuradio/header.h> model be enough?
>
> Personally I think that <gnuradio/header.h> is the right way to go. Of
> course that also mean that the pkg-config .pc must have
> -I${PREFIX}/include rather than -I${PREFIX}/include/gnuradio or else
> that defeats the point.

Hi Sylvain,
Yes, this change has already been made for the next branch / 3.7. One
of the stages is to convert all includes into this structure and make
sure the pc file properly reflects that (it does now but also has
-I${prefix}/include/gnuradio for easy compatibility right now; we're
going to remove that when we're ready).

> But the problem I see is that 3.7 is not there yet and as of now, the
> "config.h" is broken and that should be fixed ... it has also caused
> issue in some osmocom code because of name conflicts.
>
> If in 3.7 we're going to have to change include <gr_xxx.h> to include
> <gnuradio/xxx.h> anyway, then using gr_config.h now seems appropriate.
>
> Cheers,
>
>     Sylvain

Yes, I agree with you. We always hate to change things like this on
master, but the fact that we might be bringing in the file as
"#include <config.h>" right now is, as you say, broken.

I would follow your recommendation and change config.h to gr_config.h
for 3.6 as it's probably not used widely right now and those using it
are most likely people listening to this conversation. I'm going to
bounce this off Johnathan and make a decision later today.

Thanks,
Tom