Hello,
I agree. Just do a wrapper. And may be review also GETPOST to use also filter_var or more precisely filter_input ;)
Cedric
De : dolibarr-dev-bounces+c.gross=address@hidden [mailto:dolibarr-dev-bounces+c.gross=address@hidden] De la part de Florian Henry
Envoyé : vendredi 18 juillet 2014 10:09
À : Posts about Dolibarr ERP & CRM development and coding
Objet : Re: [Dolibarr-dev] Question about isValidUrl function
I think that native PHP fonction is now OK to ne use everywhere.
Envoyer depuis mon mobile.
"Doursenaud, Raphaël" <address@hidden> a écrit :Hi Marcos,
I wouldn't delete parameters because there may be some external modules that rely on this function.
But I think we could benefit from using it as a wrapper to php native functions and maybe deprecate it so module developers know they should use the native functions directly.
What do you think?
2014-07-17 21:23 GMT+02:00 Marcos García <address@hidden>:
Hi all:
I've been looking at isValidUrl function (located in core/lib/functions2.lib.php) and it has multiple parameters that are not used all over Dolibarr code.
Also, there's already a function in the core of PHP that does the same. Can we replace all the preg checks (that have high CPU cost) with the filter_var function or is there any reason why those checks are there?
Regards,
_______________________________________________
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
--
Technopole Hélioparc
2 avenue du Président Pierre Angot
64053 PAU CEDEX 9
SARL GPC.solutions au capital de 7 500 € - R.C.S. PAU 528 995 921
_______________________________________________
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
