[Dolibarr-dev] Question about isValidUrl function

[Marcos García]

Hi all:

I've been looking at isValidUrl function (located in core/lib/functions2.lib.php) and it has multiple parameters that are not used all over Dolibarr code.

https://github.com/Dolibarr/dolibarr/blob/develop/htdocs/core/lib/functions2.lib.php#405

Also, there's already a function in the core of PHP that does the same. Can we replace all the preg checks (that have high CPU cost) with the filter_var function or is there any reason why those checks are there?

​

Regards,

 

Marcos García

address@hidden