Re: [PATCH] Unicode Lisp reader escapes

[Aidan Kehoe]

 Ar an dara lá de mí Bealtaine, scríobh Eli Zaretskii: 

 > >  > First of all, is it safe to call Lisp program in read_escape? Don't we
 > >  > have to care about GC and buffer/string-data relocation?
 > > 
 > > Yay, a technical objection. 
 > 
 > I don't know what you mean: the other objections were technical as
 > well.

I would rate questions of aesthetics (“ugliness”) and prose style as
non-technical. I don’t propose to impose that judgement on you, but I do
think it reasonable.

 > > If it isn't safe to call a Lisp program in read_escape, then the
 > > function is full of bugs already.
 > 
 > ``Full of bugs''?

Indeed; each READCHAR can call arbitrary Lisp, so something like

    case 'M':
      c = READCHAR;
      if (c != '-')
        error ("Invalid escape character syntax");
      c = READCHAR;
      if (c == '\\')
        c = read_escape (readcharfun, 0, byterep);
      return c | meta_modifier;

has two clear bugs in eight lines. 

-- 
Aidan Kehoe, http://www.parhasard.net/