emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Unicode Lisp reader escapes


From: Kenichi Handa
Subject: Re: [PATCH] Unicode Lisp reader escapes
Date: Tue, 02 May 2006 20:33:44 +0900
User-agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/22.0.50 (i686-pc-linux-gnu) MULE/5.0 (SAKAKI)

In article <address@hidden>, Aidan Kehoe <address@hidden> writes:

>> First of all, is it safe to call Lisp program in read_escape? Don't we
>> have to care about GC and buffer/string-data relocation?

> Yay, a technical objection. 

> If it isn’t safe to call a Lisp program in read_escape, then the function is
> full of bugs already. It’s called with three arguments, a Lisp_Object
> readcharfun, an integer, and a pointer to an integer. If readcharfun is a
> Lisp function (it may not be, it may be a buffer, a marker, or a string),
> then that Lisp function is called on line 348. Cf. the documentation of
> `read', which describes that the input may be from a function. 

What I concern is the case that readcharfun is a string or a
buffer.  In that case, of course, the current code doesn't
call Lisp in read_escape.  So, there's no need of GCPRO
readcharfun.  But, if Lisp is called even if readcharfun is
a string, I think we should GCPRO it.  Is it already done?
(Sorry, I don't have a time to check lread.c by myself)

---
Kenichi Handa
address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]